[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui: fix keymap file search in input-barrier object
|
From: |
Anthony PERARD |
|
Subject: |
Re: [PATCH] ui: fix keymap file search in input-barrier object |
|
Date: |
Tue, 24 Sep 2019 12:10:47 +0100 |
|
User-agent: |
Mutt/1.12.2 (2019-09-21) |
On Tue, Sep 24, 2019 at 12:06:58AM +0200, Laurent Vivier wrote:
> If we try to start QEMU with "-k en-us", qemu prints a message and exits
> with:
>
> qemu-system-i386: could not read keymap file: 'en-us'
>
> It's because this function is called way too early, before
> qemu_add_data_dir() is called, and so qemu_find_file() fails.
>
> To fix that, move init_keyboard_layout() from the class init function to the
> instance init function.
>
> Reported-by: Anthony PERARD <address@hidden>
> Fixes: 6105683da35b ("ui: add an embedded Barrier client")
> Signed-off-by: Laurent Vivier <address@hidden>
Thanks!
With the patch apply, I can start QEMU (with -k).
And the patch looks fine.
Reviewed-by: Anthony PERARD <address@hidden>
--
Anthony PERARD