[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] migration: remove sent parameter in get_queued_page_not_
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 3/3] migration: remove sent parameter in get_queued_page_not_dirty |
Date: |
Tue, 24 Sep 2019 11:19:19 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Wei Yang (address@hidden) wrote:
> This is a cleanup for previous removal of unsentmap.
>
> The sent parameter is not necessary now.
>
> Signed-off-by: Wei Yang <address@hidden>
OK, you did...
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 2 +-
> migration/trace-events | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 066eb4755f..a6d3d09ebd 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2348,7 +2348,7 @@ static bool get_queued_page(RAMState *rs,
> PageSearchStatus *pss)
> dirty = test_bit(page, block->bmap);
> if (!dirty) {
> trace_get_queued_page_not_dirty(block->idstr,
> (uint64_t)offset,
> - page, test_bit(page, block->bmap));
> + page);
> } else {
> trace_get_queued_page(block->idstr, (uint64_t)offset, page);
> }
> diff --git a/migration/trace-events b/migration/trace-events
> index 00ffcd5930..858d415d56 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -76,7 +76,7 @@ qemu_file_fclose(void) ""
>
> # ram.c
> get_queued_page(const char *block_name, uint64_t tmp_offset, unsigned long
> page_abs) "%s/0x%" PRIx64 " page_abs=0x%lx"
> -get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset,
> unsigned long page_abs, int sent) "%s/0x%" PRIx64 " page_abs=0x%lx (sent=%d)"
> +get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset,
> unsigned long page_abs) "%s/0x%" PRIx64 " page_abs=0x%lx"
> migration_bitmap_sync_start(void) ""
> migration_bitmap_sync_end(uint64_t dirty_pages) "dirty_pages %" PRIu64
> migration_bitmap_clear_dirty(char *str, uint64_t start, uint64_t size,
> unsigned long page) "rb %s start 0x%"PRIx64" size 0x%"PRIx64" page 0x%lx"
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 3/3] migration: remove sent parameter in get_queued_page_not_dirty,
Dr. David Alan Gilbert <=