Re: [PATCH v4 11/16] cputlb: Merge and move memory_notdirty_write_{prepare,complete}

[David Hildenbrand]

[...]
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -33,6 +33,7 @@
>  #include "exec/helper-proto.h"
>  #include "qemu/atomic.h"
>  #include "qemu/atomic128.h"
> +#include "translate-all.h"
>  
>  /* DEBUG defines, enable DEBUG_TLB_LOG to log to the CPU_LOG_MMU target */
>  /* #define DEBUG_TLB */
> @@ -1084,6 +1085,37 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env, 
> target_ulong addr)
>      return qemu_ram_addr_from_host_nofail(p);
>  }
>  
> +static void notdirty_write(CPUState *cpu, vaddr mem_vaddr, unsigned size,
> +                           CPUIOTLBEntry *iotlbentry, uintptr_t retaddr)

I'd probably call this notdirty_write_access() like the tracepoint.

This looks like a very nice cleanup.

Reviewed-by: David Hildenbrand <address@hidden>


-- 

Thanks,

David / dhildenb