[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/16] podman: fix command invocation
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v2 05/16] podman: fix command invocation |
Date: |
Mon, 23 Sep 2019 14:47:17 -0400 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 19, 2019 at 06:10:04PM +0100, Alex Bennée wrote:
> From: John Snow <address@hidden>
>
> Oops; there's no argv here.
>
> Signed-off-by: John Snow <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Tested-by: Cleber Rosa <address@hidden>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 4dca6006d2f..890e874ba93 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -338,7 +338,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
> --
> 2.20.1
>
>
- [PATCH v2 00/16] testing/next (docker/podman, tcg, build fixes), Alex Bennée, 2019/09/19
- [PATCH v2 05/16] podman: fix command invocation, Alex Bennée, 2019/09/19
- Re: [PATCH v2 05/16] podman: fix command invocation,
Cleber Rosa <=
- [PATCH v2 12/16] tests/docker: Add fedora-win10sdk-cross image, Alex Bennée, 2019/09/19
- [PATCH v2 15/16] docs/devel: add "check-tcg" to testing.rst, Alex Bennée, 2019/09/19
- [PATCH v2 11/16] tests/tcg: add simple record/replay smoke test for aarch64, Alex Bennée, 2019/09/19
- [PATCH v2 14/16] configure: preserve PKG_CONFIG for subdir builds, Alex Bennée, 2019/09/19
- [PATCH v2 16/16] Makefile: fix-up qemu-ga.8 paths to take in-src builds into account, Alex Bennée, 2019/09/19
- [PATCH v2 13/16] .shippable.yml: Build WHPX enabled binaries, Alex Bennée, 2019/09/19
- [PATCH v2 10/16] tests/tcg: add generic version of float_convs, Alex Bennée, 2019/09/19