Re: [PATCH v2 1/5] docker: move tests from python2 to python3

[Cleber Rosa]

On Sat, Sep 21, 2019 at 10:48:06AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/21/19 12:12 AM, John Snow wrote:
> > As part of the push to drop python2 support, replace any explicit python2
> > dependencies with python3 versions.
> > 
> > For centos, python2 still exists as an implicit dependency, but by adding
> > python3 we will be able to build even if the configure script begins to
> > require python 3.5+.
> > 
> > Tested with centos7, fedora, ubuntu, ubuntu1804, and debian 9 (amd64).
> > Tested under a custom configure script that requires Python 3.5+.
> > 
> > the travis dockerfile is also moved to using python3, which was tested
> > by running `make docker-test-build@travis`, which I hope is sufficient.
> > 
> > Signed-off-by: John Snow <address@hidden>
> 
> > Message-id: address@hidden
>   ^ remove
> 
> v1 has:
> Reviewed-by: Eduardo Habkost <address@hidden>
> 
> > ---
> >  tests/docker/dockerfiles/centos7.docker             | 2 +-
> >  tests/docker/dockerfiles/debian-ports.docker        | 2 +-
> >  tests/docker/dockerfiles/debian-sid.docker          | 2 +-
> >  tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 +-
> >  tests/docker/dockerfiles/debian10.docker            | 2 +-
> >  tests/docker/dockerfiles/debian8.docker             | 3 +--
> 
> If you queue this patch at the end of your series, no need to patch
> debian8.docker.
>

Yep, agreed.

- Cleber.