[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2), personal
|
From: |
Sergio Lopez |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2), personality (virtio-1) |
|
Date: |
Mon, 23 Sep 2019 15:58:28 +0200 |
|
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Vasyl Vavrychuk <address@hidden> writes:
> Hi, Sergio,
>
>> For this reason, the v2 personality is disabled, keeping the legacy
>> behavior as default. Machine types willing to use v2, can enable it
>> using MachineClass's compat_props.
> ...
>> + DEFINE_PROP_BOOL("force-legacy", VirtIOMMIOProxy, legacy, true),
>
> Currently, I am not enable to set "force-legacy" to false from command
> line for
> virt machine.
You can disable force-legacy from the command line by passing "-global
virtio-mmio.force-legacy=false".
> I think, the "force-legacy" and compat_props should work the other way
> around.
>
> The "force-legacy" should be set to false by default to select a new
> behaviour.
> Instead of this hw_compat_4_1 should be modified to keep the old behaviour:
The decision to keep the legacy behavior as the default is because
support for the non-legacy personality is not a widespread as it'd be
desirable. Basically, only the Linux guest driver supports it (it's
missing from every *BSD I checked, and also from TianoCore's EDK2).
Sergio.
signature.asc
Description: PGP signature