[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/16] docs/devel/qapi-code-gen: Rewrite comp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations |
Date: |
Mon, 23 Sep 2019 08:00:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/23/19 6:44 AM, Markus Armbruster wrote:
>>>> Worth mentioning that type names themselves are NOT part of the
>>>> interface, and may be freely renamed?
>>>
>>> Care to suggest a suitable sentence?
>>
>> Although member names within a type cannot be changed without affecting
>> compatibility,
>
> This part seems redundant with the previous paragraph.
>
>> changes to type names themselves do not affect the
>> protocol. As such, complex types may be freely renamed or refactored,
>
> All types (enums, structs, simple & flat unions, alternates) actually,
> not just complex ones (structs, unions).
>
>> such as splitting members from one type into a common base type, as long
>> as the resulting set of members remain compatible.
>
> What does it mean for a set of members to be compatible? We don't
> actually define that...
>
> What about:
>
> Since type names are not visible in the Client JSON Protocol, types
> may be freely renamed. Even certain refactorings are invisible, such
> as splitting members from one type into a common base type.
Seems reasonable to me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt, (continued)
[Qemu-devel] [PATCH v2 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema, Markus Armbruster, 2019/09/10
[Qemu-devel] [PATCH v2 08/16] qapi: Permit 'boxed' with empty type, Markus Armbruster, 2019/09/10
[Qemu-devel] [PATCH v2 15/16] docs/devel/qapi-code-gen: Improve QAPI schema language doc, Markus Armbruster, 2019/09/10