[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses
From: |
David Hildenbrand |
Subject: |
[PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses |
Date: |
Mon, 23 Sep 2019 10:06:50 +0200 |
We have to mask of any unused bits. While at it, document what exactly is
missing.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 7dfa848744..746f647303 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -679,8 +679,15 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0,
uint64_t r1, uint64_t r2)
s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, GETPC());
}
- /* ??? missing r0 handling, which includes access keys, but more
- importantly optional suppression of the exception! */
+ r1 = wrap_address(env, r1 & TARGET_PAGE_MASK);
+ r2 = wrap_address(env, r2 & TARGET_PAGE_MASK);
+
+ /*
+ * TODO:
+ * - Access key handling
+ * - CC-option with surpression of page-translation exceptions
+ * - Store r1/r2 register identifiers at real location 162
+ */
fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, GETPC());
return 0; /* data moved */
}
--
2.21.0
- [PULL 00/30] s390x/tcg update, David Hildenbrand, 2019/09/23
- [PULL 01/30] s390x/tcg: Reset exception_index to -1 instead of 0, David Hildenbrand, 2019/09/23
- [PULL 02/30] s390x/tcg: MVCL: Zero out unused bits of address, David Hildenbrand, 2019/09/23
- [PULL 03/30] s390x/tcg: MVCL: Detect destructive overlaps, David Hildenbrand, 2019/09/23
- [PULL 04/30] s390x/tcg: MVCL: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 05/30] s390x/tcg: MVC: Increment the length once, David Hildenbrand, 2019/09/23
- [PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap(), David Hildenbrand, 2019/09/23
- [PULL 07/30] s390x/tcg: MVPG: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses,
David Hildenbrand <=
- [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 10/30] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/23
- [PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/23
- [PULL 12/30] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/23
- [PULL 13/30] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 14/30] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/23
- [PULL 15/30] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/23
- [PULL 16/30] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/23
- [PULL 17/30] s390x/tcg: Fault-safe memmove, David Hildenbrand, 2019/09/23
- [PULL 18/30] s390x/tcg: MVCS/MVCP: Use access_memmove(), David Hildenbrand, 2019/09/23