[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DE
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 4/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG |
Date: |
Sat, 21 Sep 2019 11:01:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/20/19 1:29 AM, Richard Henderson wrote:
> This reduces the size of a release build by about 10k.
> Noticably, within the tlb miss helpers.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> include/exec/cpu-all.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> index a53b761b48..b11ee1f711 100644
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -215,7 +215,11 @@ typedef struct {
> int bits;
> } TargetPageBits;
> extern const TargetPageBits target_page;
> -#define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
> +# ifdef CONFIG_DEBUG_TCG
> +# define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
> +# else
> +# define TARGET_PAGE_BITS target_page.bits
> +# endif
> #else
> #define TARGET_PAGE_BITS_MIN TARGET_PAGE_BITS
> #endif
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [PATCH 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/19
- [PATCH 1/7] exec: Use TARGET_PAGE_BITS_MIN for TLB flags, Richard Henderson, 2019/09/19
- [PATCH 2/7] exec: Split out variable page size support to exec-vary.c, Richard Henderson, 2019/09/19
- [PATCH 4/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG, Richard Henderson, 2019/09/19
- Re: [PATCH 4/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG,
Philippe Mathieu-Daudé <=
- [PATCH 3/7] exec: Use const alias for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/19
- [PATCH 5/7] exec: Promote TARGET_PAGE_MASK to target_long, Richard Henderson, 2019/09/19
- [PATCH 7/7] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY, Richard Henderson, 2019/09/19
- [PATCH 6/7] exec: Tidy TARGET_PAGE_ALIGN, Richard Henderson, 2019/09/19
- Re: [PATCH 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY, Paolo Bonzini, 2019/09/20
- Re: [PATCH 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY, no-reply, 2019/09/20