[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/i386: clean up comments over 80 chars per line
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v2] target/i386: clean up comments over 80 chars per line |
|
Date: |
Fri, 20 Sep 2019 15:29:58 -0300 |
On Fri, Sep 20, 2019 at 11:14:56AM +0200, Stefano Garzarella wrote:
> On Fri, Sep 20, 2019 at 01:31:36PM +0800, Tao Xu wrote:
> > Drop the duplicate definition of CPUID_7_0_ECX_VBMI. And add some
> > comments, clean up comments over 80 chars per line.
> >
> > There is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD,
> > remove the extra enter and spaces.
>
> Might it be better to split this patch into two?
>
> One where you fix the comments over 80 chars rand one where you drop the
> CPUID_7_0_ECX_VBMI definition.
Yes, please. The subject line implies the only changes are in
comment formatting, but the patch is replacing a macro.
--
Eduardo