Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

[David Hildenbrand]

On 19.09.19 18:01, Richard Henderson wrote:
> On 9/19/19 2:41 AM, David Hildenbrand wrote:
>>> +    /* prepare the buffers - two consecutive pages */
>>> +    src = valloc(ALLOC_SIZE);
>>> +    dst = valloc(ALLOC_SIZE);
>>
>> If anybody cares, I can convert the obsolete valloc into a
>> posix_memalign(&src, 4096, ALLOC_SIZE) etc.
> 
> I don't care.  It may be obsolete, but it still works.
> 
> If you were to change it to anything I would think mmap
> instead of using mprotect on the heap at all...

Yeah, that was my other thought, but after all I own "full" pages.

I'll leave it like this than unless somebody objects :)

> 
> Reviewed-by: Richard Henderson <address@hidden>

Thanks!

> 
> 
> r~
> 


-- 

Thanks,

David / dhildenb