[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-web PATCH] Gemfile: use a fixed version of sassc
From: |
Thomas Huth |
Subject: |
Re: [qemu-web PATCH] Gemfile: use a fixed version of sassc |
Date: |
Thu, 19 Sep 2019 17:38:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 19/09/2019 15.01, Paolo Bonzini wrote:
> Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
> Gemfile was requiring an earlier version (2.1.0 in practice).
> Since the bug has been fixed, remove the workaround and instead
> require a fixed version.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> Gemfile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Gemfile b/Gemfile
> index b76a4fd..2117bba 100644
> --- a/Gemfile
> +++ b/Gemfile
> @@ -24,4 +24,4 @@ group :jekyll_plugins do
> end
>
> # for https://github.com/sass/sassc-ruby/issues/146
> -gem "sassc", "< 2.2.0"
> +gem "sassc", ">= 2.2.1"
I think you could simply drop the two lines now, "bundle install" will
pick up the newer version anyway.
Both ways work for me, so for any of the two solutions:
Tested-by: Thomas Huth <address@hidden>