Re: [Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

[Alex Bennée]

Peter Maydell <address@hidden> writes:

> On Thu, 19 Sep 2019 at 02:25, Eric Blake <address@hidden> wrote:
>>
>> On 9/13/19 10:49 AM, Peter Maydell wrote:
>> > The qemu-ga documentation is currently in qemu-ga.texi in
>> > Texinfo format, which we present to the user as:
>> >  * a qemu-ga manpage
>> >  * a section of the main qemu-doc HTML documentation
>> >
>> > Convert the documentation to rST format, and present it to
>> > the user as:
>> >  * a qemu-ga manpage
>> >  * part of the interop/ Sphinx manual
>> >
>> > Signed-off-by: Peter Maydell <address@hidden>
>> > Reviewed-by: Michael Roth <address@hidden>
>> > Tested-by: Michael Roth <address@hidden>
>> > Message-id: address@hidden
>> > ---
>>
>> In an incremental build on Fedora 30, I'm now seeing:
>>
>>         CHK version_gen.h
>>   GEN     docs/interop/qemu-ga.8
>> No filename or title
>> make: *** [/home/eblake/qemu/rules.mak:394: docs/interop/qemu-ga.8]
>> Error 255
>>
>> and suspect this patch introduced it.  It may be that I just need to
>> nuke intermediate artifacts rather than an actual problem with the
>> patch, but I'd welcome help in identifying the problem.
>
> If you build with V=1 what does it say it's doing?

This is what shippable shows:

make -I/root/src/github.com/stsquad/qemu/dtc 
VPATH=/root/src/github.com/stsquad/qemu/dtc -C dtc V="1" 
LIBFDT_srcdir=/root/src/github.com/stsquad/qemu/dtc/libfdt 
CPPFLAGS="-I/root/src/github.com/stsquad/qemu/dtc 
-I/root/src/github.com/stsquad/qemu/dtc 
-I/root/src/github.com/stsquad/qemu/dtc/libfdt" CFLAGS="-O2 -U_FORTIFY_SOURCE 
-D_FORTIFY_SOURCE=2 -g  -I/usr/include/pixman-1 
-I/root/src/github.com/stsquad/qemu/dtc/libfdt -Werror  -pthread 
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE 
-DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings 
-Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99  
-Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body 
-Wnested-externs -Wformat-security -Wformat-y2k -Winit-self 
-Wignored-qualifiers -Wold-style-declaration -Wold-style-definition 
-Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1    
-I/usr/include/libpng16  -I/usr/include/spice-server -I/usr/include/spice-1 
-I/root/src/github.com/stsquad/qemu/capstone/include 
-I/root/src/github.com/stsquad/qemu/tests" LDFLAGS="-Wl,--warn-common 
-Wl,-z,relro -Wl,-z,now -pie -m64 -g " ARFLAGS="rv" CC="cc" AR="ar" LD="ld"  
BUILD_DIR=/root/src/github.com/stsquad/qemu libfdt/libfdt.a
if ! cmp -s qemu-version.h qemu-version.h.tmp; then mv qemu-version.h.tmp 
qemu-version.h; else rm qemu-version.h.tmp; fi
make[1]: Entering directory '/root/src/github.com/stsquad/qemu/dtc'
make[1]: Entering directory '/root/src/github.com/stsquad/qemu/slirp'
make -C /root/src/github.com/stsquad/qemu/capstone CAPSTONE_SHARED=no 
BUILDDIR="/root/src/github.com/stsquad/qemu/capstone" CC="cc" AR="ar" LD="ld" 
RANLIB="ranlib" CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g 
-I/usr/include/pixman-1 -I/root/src/github.com/stsquad/qemu/dtc/libfdt -pthread 
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE 
-DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -fstack-protector-strong 
-I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-server 
-I/usr/include/spice-1 -I/root/src/github.com/stsquad/qemu/capstone/include 
-I/root/src/github.com/stsquad/qemu/tests -DCAPSTONE_USE_SYS_DYN_MEM 
-DCAPSTONE_HAS_ARM -DCAPSTONE_HAS_ARM64 -DCAPSTONE_HAS_POWERPC 
-DCAPSTONE_HAS_X86"  BUILD_DIR=/root/src/github.com/stsquad/qemu 
/root/src/github.com/stsquad/qemu/capstone/libcapstone.a
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/root/src/github.com/stsquad/qemu/slirp'
make[1]: Entering directory '/root/src/github.com/stsquad/qemu/capstone'
set -e; echo '  CHK version_gen.h'; mkdir -p ./;        (echo "#define 
DTC_VERSION \"DTC 1.4.7\""; ) < Makefile > version_gen.h.tmp; if [ -r 
version_gen.h ] && cmp -s version_gen.h version_gen.h.tmp; then rm -f 
version_gen.h.tmp; else echo '       UPD version_gen.h'; mv -f 
version_gen.h.tmp version_gen.h; fi;
        CHK version_gen.h
make[1]: '/root/src/github.com/stsquad/qemu/capstone/libcapstone.a' is up to 
date.
make[1]: Leaving directory '/root/src/github.com/stsquad/qemu/capstone'
make[1]: 'libfdt/libfdt.a' is up to date.
make[1]: Leaving directory '/root/src/github.com/stsquad/qemu/dtc'
cc -iquote /root/src/github.com/stsquad/qemu/tests/qemu-iotests -iquote 
tests/qemu-iotests -iquote /root/src/github.com/stsquad/qemu/tcg -iquote 
/root/src/github.com/stsquad/qemu/tcg/i386 
-I/root/src/github.com/stsquad/qemu/linux-headers 
-I/root/src/github.com/stsquad/qemu/linux-headers -iquote . -iquote 
/root/src/github.com/stsquad/qemu -iquote 
/root/src/github.com/stsquad/qemu/accel/tcg -iquote 
/root/src/github.com/stsquad/qemu/include -I/usr/include/pixman-1 
-I/root/src/github.com/stsquad/qemu/dtc/libfdt -Werror  -pthread 
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE 
-DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings 
-Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99  
-Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body 
-Wnested-externs -Wformat-security -Wformat-y2k -Winit-self 
-Wignored-qualifiers -Wold-style-declaration -Wold-style-definition 
-Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1    
-I/usr/include/libpng16  -I/usr/include/spice-server -I/usr/include/spice-1 
-I/root/src/github.com/stsquad/qemu/capstone/include 
-I/root/src/github.com/stsquad/qemu/tests -MMD -MP -MT 
tests/qemu-iotests/socket_scm_helper.o -MF 
tests/qemu-iotests/socket_scm_helper.d -O2 -U_FORTIFY_SOURCE 
-D_FORTIFY_SOURCE=2 -g   -c -o tests/qemu-iotests/socket_scm_helper.o 
tests/qemu-iotests/socket_scm_helper.c
( echo "@set VERSION 4.1.50" && echo "@set CONFDIR /usr/local/etc/qemu" )> 
docs/version.texi
sh /root/src/github.com/stsquad/qemu/scripts/hxtool -t < 
/root/src/github.com/stsquad/qemu/qemu-options.hx > qemu-options.texi
sh /root/src/github.com/stsquad/qemu/scripts/hxtool -t < 
/root/src/github.com/stsquad/qemu/hmp-commands.hx > qemu-monitor.texi
sh /root/src/github.com/stsquad/qemu/scripts/hxtool -t < 
/root/src/github.com/stsquad/qemu/qemu-img-cmds.hx > qemu-img-cmds.texi
sh /root/src/github.com/stsquad/qemu/scripts/hxtool -t < 
/root/src/github.com/stsquad/qemu/hmp-commands-info.hx > qemu-monitor-info.texi
perl -Ww -- /root/src/github.com/stsquad/qemu/scripts/texi2pod.pl -I docs -I . 
-I . -DVERSION="4.1.50" -DCONFDIR="/usr/local/etc/qemu" qemu-img.texi 
qemu-img.1.pod && pod2man --utf8 --section=1 --center=" " --release=" " 
qemu-img.1.pod > qemu-img.1
perl -Ww -- /root/src/github.com/stsquad/qemu/scripts/texi2pod.pl -I docs -I . 
-I . -DVERSION="4.1.50" -DCONFDIR="/usr/local/etc/qemu" qemu-nbd.texi 
qemu-nbd.8.pod && pod2man --utf8 --section=8 --center=" " --release=" " 
qemu-nbd.8.pod > qemu-nbd.8
perl -Ww -- /root/src/github.com/stsquad/qemu/scripts/texi2pod.pl -I docs -I 
scripts -I docs/interop -DVERSION="4.1.50" -DCONFDIR="/usr/local/etc/qemu" 
scripts/texi2pod.pl docs/interop/qemu-ga.8.pod && pod2man --utf8 --section=8 
--center=" " --release=" " docs/interop/qemu-ga.8.pod > docs/interop/qemu-ga.8
python3 -B /root/src/github.com/stsquad/qemu/scripts/qapi-gen.py -o 
qga/qapi-generated -p "qga-" 
/root/src/github.com/stsquad/qemu/qga/qapi-schema.json
No filename or title
/root/src/github.com/stsquad/qemu/rules.mak:394: recipe for target 
'docs/interop/qemu-ga.8' failed
make: *** [docs/interop/qemu-ga.8] Error 255
make: *** Waiting for unfinished jobs....

--
Alex Bennée