[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Fix tarball builds of UEFI/EDK2 firmware
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Fix tarball builds of UEFI/EDK2 firmware |
|
Date: |
Thu, 19 Sep 2019 15:51:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/13/19 1:12 AM, Michael Roth wrote:
> Bruce noticed that we cannot build `make efi` target from the v4.1.0
> tarball. This is due to a failure on the part of the make-release script
> to pull in submodules nested under other submodules, as well as
> Makefile.edk2's assumptions about being in a git tree.
Hmm I'd expect distributions interested in building EDK2, build it
properly tuned, outside of QEMU. I consider what is here as default
config useful for testing, not for production use. I might be wrong.
Meanwhile, it is true 'make efi' should not fail.
> Suggestions for more robust solutions are definitely welcome, but for
> now this series takes what seems to be the most direct approach.
This is fine:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
I'll queue these patches in my edk2-next branch since I'm preparing a
pull request.
Thanks,
Phil.