Re: [Qemu-devel] [RESEND PATCH] tests/acceptance: Specify arch for QueryCPUModelExpansion

[Philippe Mathieu-Daudé]

On 9/18/19 9:06 AM, David Gibson wrote:
> At the moment this test runs on whatever the host arch is.  But it looks
> for 'unavailable-features' which is an x86 specific cpu property.  Tag it
> to always use qemu-system-x86_64.
> 
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
> ---
>  tests/acceptance/cpu_queries.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> I sent this a while back, but it seems to have been forgotten.  As far
> as I can tell the current logic is Just Plain Wrong, on any host other
> than x86.
> 
> diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
> index e71edec39f..af47d2795a 100644
> --- a/tests/acceptance/cpu_queries.py
> +++ b/tests/acceptance/cpu_queries.py
> @@ -18,6 +18,9 @@ class QueryCPUModelExpansion(Test):
>      """
>  
>      def test(self):
> +        """
> +        :avocado: tags=arch:x86_64
> +        """
>          self.vm.set_machine('none')
>          self.vm.add_args('-S')
>          self.vm.launch()
> 

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>