qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/19] qapi: Delete useless check_exprs() code f


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 16/19] qapi: Delete useless check_exprs() code for simple union kind
Date: Tue, 17 Sep 2019 14:05:21 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/14/19 10:35 AM, Markus Armbruster wrote:
> Commit bceae7697f "qapi script: support enum type as discriminator in
> union" made check_exprs() add the implicit enum types of simple unions
> to global @enum_types.  I'm not sure it was needed even then.  It's
> certainly not needed now.  Delete it.
> 
> discriminator_find_enum_define() and add_name() parameter @implicit
> are now dead.  Bury them.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi/common.py | 39 ++-------------------------------------
>  1 file changed, 2 insertions(+), 37 deletions(-)
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]