[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset |
Date: |
Tue, 17 Sep 2019 13:11:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/16/19 9:57 AM, David Hildenbrand wrote:
> Replace fast_memset() by access_memset(), that first tries to probe
> access to all affected pages (maximum is two). We'll use the same
> mechanism for other types of accesses soon.
>
> Only in very rare cases (especially TLB_NOTDIRTY), we'll have to
> fallback to ld/st helpers. Try to speed up that case as suggested by
> Richard.
>
> We'll rework most involved handlers soon to do all accesses via new
> fault-safe helpers, especially MVC.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/mem_helper.c | 123 +++++++++++++++++++++++++++++++-------
> 1 file changed, 103 insertions(+), 20 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v3 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, (continued)
- [Qemu-devel] [PATCH v3 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 11/29] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 13/29] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 14/29] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 15/29] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/16
- Re: [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 17/29] s390x/tcg: Fault-safe memmove, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove(), David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 19/29] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 20/29] s390x/tcg: MVCLU: Fault-safe handling, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 21/29] s390x/tcg: OC: Fault-safe handling, David Hildenbrand, 2019/09/16
- [Qemu-devel] [PATCH v3 22/29] s390x/tcg: XC: Fault-safe handling, David Hildenbrand, 2019/09/16