[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative t
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq |
|
Date: |
Tue, 17 Sep 2019 12:25:49 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/17/19 12:14 PM, Peter Maydell wrote:
>> +static Property arm_cpu_gt_cntfrq_property =
>> + DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq,
>> + (1000 * 1000 * 1000) / GTIMER_SCALE);
> I think it would be helpful to have a comment saynig what units
> this property is in.
>
Should this be NANOSECONDS_PER_SECOND?
It's certainly a suspicious use of 1e9 otherwise.
r~