Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

[Alex Bennée]

John Snow <address@hidden> writes:

> It's not used; so remove the distraction.

It's a developer feature so you can run specific builds against the VM
images. I certainly have used it, unless you are saying it's broken now?

>
> Signed-off-by: John Snow <address@hidden>
> ---
>  tests/vm/Makefile.include | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index fea348e845..61758101fa 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -28,7 +28,6 @@ vm-help vm-test:
>       @echo
>       @echo "Special variables:"
>       @echo "    BUILD_TARGET=foo              - Override the build target"
> -     @echo "    TARGET_LIST=a,b,c             - Override target list in 
> builds"
>       @echo '    EXTRA_CONFIGURE_OPTS="..."'
>       @echo "    J=[0..9]*                     - Override the -jN parameter 
> for make commands"
>       @echo "    DEBUG=1                       - Enable verbose output on 
> host and interactive debugging"
> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>               $(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>               --snapshot \
>               --build-qemu $(SRC_PATH) -- \
> -             $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>               $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>               "  VM-BUILD $*")


--
Alex Bennée