[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qapi: Add feature flags to commands in qapi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qapi: Add feature flags to commands in qapi introspection |
Date: |
Tue, 17 Sep 2019 11:03:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/17/19 10:49 AM, Peter Krempa wrote:
> Similarly to features for struct types introduce the feature flags also
> for commands. This will allow notifying management layers of fixes and
> compatible changes in the behaviour of an command which may not be
s/ an / a /
> detectable any other way.
>
> The changes were heavily inspired by commit 6a8c0b51025.
>
> Signed-off-by: Peter Krempa <address@hidden>
> ---
> docs/devel/qapi-code-gen.txt | 4 ++--
May be some rebase churn needed here as Markus has been reworking that file:
https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg02959.html
> qapi/introspect.json | 6 ++++-
> scripts/qapi/commands.py | 3 ++-
> scripts/qapi/common.py | 40 +++++++++++++++++++++++++++++-----
> scripts/qapi/doc.py | 3 ++-
> scripts/qapi/introspect.py | 7 +++++-
> tests/qapi-schema/test-qapi.py | 7 +++++-
> 7 files changed, 58 insertions(+), 12 deletions(-)
>
> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
> index e8ec8ac1de..38682daace 100644
> --- a/docs/devel/qapi-code-gen.txt
> +++ b/docs/devel/qapi-code-gen.txt
> @@ -726,8 +726,8 @@ change in the QMP syntax (usually by allowing values or
> operations that
> previously resulted in an error). QMP clients may still need to know
> whether the extension is available.
>
> -For this purpose, a list of features can be specified for a struct type.
> -This is exposed to the client as a list of string, where each string
> +For this purpose, a list of features can be specified for a command or struct
> +type. This is exposed to the client as a list of string, where each string
Pre-existing, but "list of strings" or "list of string entries"
> signals that this build of QEMU shows a certain behaviour.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature