[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/29] exec.c: add a check between constants to see w
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 06/29] exec.c: add a check between constants to see whether we could skip |
Date: |
Mon, 16 Sep 2019 16:41:46 +0200 |
From: Wei Yang <address@hidden>
The maximum level is defined as P_L2_LEVELS and skip is defined with 6
bits, which means if P_L2_LEVELS < (1 << 6), skip never exceeds the
boundary.
Since this check is between two constants, which leverages compiler
to optimize the code based on different configuration.
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
exec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index d1969bb..b9511be 100644
--- a/exec.c
+++ b/exec.c
@@ -324,7 +324,8 @@ static void phys_page_compact(PhysPageEntry *lp, Node
*nodes)
assert(valid_ptr < P_L2_SIZE);
/* Don't compress if it won't fit in the # of bits we have. */
- if (lp->skip + p[valid_ptr].skip >= (1 << 6)) {
+ if (P_L2_LEVELS >= (1 << 6) &&
+ lp->skip + p[valid_ptr].skip >= (1 << 6)) {
return;
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/29] Misc patches for 2019-09-16, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 01/29] i386/kvm: support guest access CORE cstate, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 02/29] exec.c: replace hwaddr with uint64_t for better understanding, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 03/29] exec.c: get nodes_nb_alloc with one MAX calculation, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 04/29] exec.c: subpage->sub_section is already initialized to 0, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 06/29] exec.c: add a check between constants to see whether we could skip,
Paolo Bonzini <=
- [Qemu-devel] [PULL 05/29] exec.c: correct the maximum skip value during compact, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 07/29] win32: fix README file in NSIS installer, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 08/29] test-char: fix AddressSanitizer failure, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 09/29] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 10/29] elf-ops.h: fix int overflow in load_elf(), Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 12/29] memory: inline and optimize devend_memop, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 11/29] memory: fetch pmem size in get_file_size(), Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 15/29] hw/i386/pc: Use e820_get_num_entries() to access e820_entries, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 14/29] cpus: Fix throttling during vm_stop, Paolo Bonzini, 2019/09/16
- [Qemu-devel] [PULL 16/29] hw/i386/pc: Extract e820 memory layout code, Paolo Bonzini, 2019/09/16