[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/2] target/hppa: prevent trashing of temporary in do
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 2/2] target/hppa: prevent trashing of temporary in do_depw_sar() |
Date: |
Sun, 15 Sep 2019 09:49:44 -0400 |
From: Sven Schnelle <address@hidden>
nullify_over() calls brcond which destroys all temporaries.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Sven Schnelle <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/hppa/translate.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index b12525d535..c1b2822f60 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -3404,10 +3404,6 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt,
unsigned c,
TCGv_reg mask, tmp, shift, dest;
unsigned msb = 1U << (len - 1);
- if (c) {
- nullify_over(ctx);
- }
-
dest = dest_gpr(ctx, rt);
shift = tcg_temp_new();
tmp = tcg_temp_new();
@@ -3440,11 +3436,17 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt,
unsigned c,
static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a)
{
+ if (a->c) {
+ nullify_over(ctx);
+ }
return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r));
}
static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a)
{
+ if (a->c) {
+ nullify_over(ctx);
+ }
return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a->i));
}
--
2.17.1