qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tests/tcg: add float_madds test to multiarch


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] tests/tcg: add float_madds test to multiarch
Date: Sat, 14 Sep 2019 11:12:13 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/13/19 9:49 AM, Alex Bennée wrote:
> +                    /* must be built with -O2 to generate fused op */
> +                    r = a * b + c;

I would prefer to use fmaf() or __builtin_fmaf() here.

Although you'll need to link with -lm just in case the
target doesn't support an instruction for fmaf and so
the builtin expands to the standard library call.

I also like Paul's suggestion to use hex float constants.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]