[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 3/6] target/arm: handle A-profile semihosting at
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v6 3/6] target/arm: handle A-profile semihosting at translate time |
Date: |
Fri, 13 Sep 2019 16:18:42 +0100 |
As for the other semihosting calls we can resolve this at translate
time.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
v2
- update for change to gen_exception_internal_insn API
v3
- update for decode tree, merge T32 & A32 commits
- dropped r-b due to changes
v4
- !IS_USER and !arm_dc_feature(s, ARM_FEATURE_M)
v5
- only if !IS_USER for softmmu, linux-user is still allowed
---
target/arm/translate.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index b5272119330..698c594e8ce 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -10222,14 +10222,25 @@ static bool trans_CBZ(DisasContext *s, arg_CBZ *a)
}
/*
- * Supervisor call
+ * Supervisor call - both T32 & A32 come here so we need to check
+ * which mode we are in when checking for semihosting.
*/
static bool trans_SVC(DisasContext *s, arg_SVC *a)
{
- gen_set_pc_im(s, s->base.pc_next);
- s->svc_imm = a->imm;
- s->base.is_jmp = DISAS_SWI;
+ const uint32_t semihost_imm = s->thumb ? 0xab : 0x123456;
+
+ if (!arm_dc_feature(s, ARM_FEATURE_M) && semihosting_enabled() &&
+#ifndef CONFIG_USER_ONLY
+ !IS_USER(s) &&
+#endif
+ (a->imm == semihost_imm)) {
+ gen_exception_internal_insn(s, s->base.pc_next, EXCP_SEMIHOST);
+ } else {
+ gen_set_pc_im(s, s->base.pc_next);
+ s->svc_imm = a->imm;
+ s->base.is_jmp = DISAS_SWI;
+ }
return true;
}
--
2.20.1
- [Qemu-devel] [PATCH v6 0/6] semihosting cleanups (plus minor tests/tcg tweak), Alex Bennée, 2019/09/13
- [Qemu-devel] [PATCH v6 2/6] target/arm: handle M-profile semihosting at translate time, Alex Bennée, 2019/09/13
- [Qemu-devel] [PATCH v6 1/6] tests/tcg: clean-up some comments after the de-tangling, Alex Bennée, 2019/09/13
- [Qemu-devel] [PATCH v6 5/6] target/arm: remove run-time semihosting checks for linux-user, Alex Bennée, 2019/09/13
- [Qemu-devel] [PATCH v6 3/6] target/arm: handle A-profile semihosting at translate time,
Alex Bennée <=
- [Qemu-devel] [PATCH v6 4/6] target/arm: remove run time semihosting checks, Alex Bennée, 2019/09/13
- [Qemu-devel] [PATCH v6 6/6] tests/tcg: add linux-user semihosting smoke test for ARM, Alex Bennée, 2019/09/13
- Re: [Qemu-devel] [PATCH v6 0/6] semihosting cleanups (plus minor tests/tcg tweak), Peter Maydell, 2019/09/17