Re: [Qemu-devel] [PATCH v3 3/6] vmstate: replace DeviceState with VMStateIf

[Marc-André Lureau]

Hi

On Thu, Sep 12, 2019 at 8:19 PM Halil Pasic <address@hidden> wrote:
>
> On Thu, 12 Sep 2019 16:25:11 +0400
> Marc-André Lureau <address@hidden> wrote:
>
> > diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
> > index d4807f7777..16b9bbf04d 100644
> > --- a/hw/s390x/s390-skeys.c
> > +++ b/hw/s390x/s390-skeys.c
> > @@ -392,7 +392,7 @@ static inline void 
> > s390_skeys_set_migration_enabled(Object *obj, bool value,
> >          register_savevm_live(NULL, TYPE_S390_SKEYS, 0, 1,
> >                               &savevm_s390_storage_keys, ss);
> >      } else {
> > -        unregister_savevm(DEVICE(ss), TYPE_S390_SKEYS, ss);
> > +        unregister_savevm(VMSTATE_IF(ss), TYPE_S390_SKEYS, ss);
> >      }
> >  }
>
> Acked-by: Halil Pasic <address@hidden>
>

thanks

> BTW what does the 'f' in VMStateIf stand for? (I've had a look
> at 2/6 but didn't figure out the answer).

"If" stands for interface, and seems to be more common in qemu.
gobject code usually uses "Iface", and other prefer "I" prefix.