[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/4] target/mips: gdbstub: Revert commit 8e0b373
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 4/4] target/mips: gdbstub: Revert commit 8e0b373 |
Date: |
Thu, 12 Sep 2019 18:30:40 +0200 |
From: Libo Zhou <address@hidden>
Multiple reports from users were received regarding failures of
packet 'g' communication with gdb for some MIPS configurations.
It was found out (by bisecting) that the problematic commit is
8e0b373. Revert that commit until a better solution is developed.
Suggested-by: Aleksandar Markovic <address@hidden>
Signed-off-by: Libo Zhou <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
---
target/mips/gdbstub.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
index ebcc98b..bbb2544 100644
--- a/target/mips/gdbstub.c
+++ b/target/mips/gdbstub.c
@@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t
*mem_buf, int n)
return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
default:
if (env->CP0_Status & (1 << CP0St_FR)) {
- return gdb_get_reg64(mem_buf,
+ return gdb_get_regl(mem_buf,
env->active_fpu.fpr[n - 38].d);
} else {
return gdb_get_regl(mem_buf,
@@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t
*mem_buf, int n)
break;
default:
if (env->CP0_Status & (1 << CP0St_FR)) {
- uint64_t tmp = ldq_p(mem_buf);
env->active_fpu.fpr[n - 38].d = tmp;
} else {
env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
--
2.7.4
- [Qemu-devel] [PULL 0/4] MIPS queue for September 12th, 2019, Aleksandar Markovic, 2019/09/12
- [Qemu-devel] [PULL 3/4] hw/mips/mips_jazz: Remove no-longer-necessary override of do_unassigned_access, Aleksandar Markovic, 2019/09/12
- [Qemu-devel] [PULL 2/4] target/mips: Switch to do_transaction_failed() hook, Aleksandar Markovic, 2019/09/12
- [Qemu-devel] [PULL 4/4] target/mips: gdbstub: Revert commit 8e0b373,
Aleksandar Markovic <=
- [Qemu-devel] [PULL 1/4] hw/mips/mips_jazz: Override do_transaction_failed hook, Aleksandar Markovic, 2019/09/12
- Re: [Qemu-devel] [PULL 0/4] MIPS queue for September 12th, 2019, Peter Maydell, 2019/09/16