Re: [Qemu-devel] [PATCH 1/3] xen / notify: introduce a new XenWatchList abstraction

[Paul Durrant]

> -----Original Message-----
> From: Anthony PERARD <address@hidden>
> Sent: 12 September 2019 11:17
> To: Paul Durrant <address@hidden>
> Cc: address@hidden; address@hidden; Stefano Stabellini <address@hidden>
> Subject: Re: [PATCH 1/3] xen / notify: introduce a new XenWatchList 
> abstraction
> 
> On Wed, Sep 11, 2019 at 03:36:16PM +0100, Paul Durrant wrote:
> > Xenstore watch call-backs are already abstracted away from XenBus using
> > the XenWatch data structure but the associated NotifierList manipulation
> > and file handle registation is still open coded in various xen_bus_...()
>                   ^ registration

Ok.

> > functions.
> > This patch creates a new XenWatchList data structure to allow these
> > interactions to be abstracted away from XenBus as well. This is in
> > preparation for a subsequent patch which will introduce separate watch lists
> > for XenBus and XenDevice objects.
> >
> > NOTE: This patch also introduces a new NotifierListEmpty() helper function
>                                          ^ notifier_list_empty() ?
> 

Oops, yes :-)

> >       for the purposes of adding an assertion that a XenWatchList is not
> >       freed whilst its associated NotifierList is still occupied.
> >
> > Signed-off-by: Paul Durrant <address@hidden>
> 
> Reviewed-by: Anthony PERARD <address@hidden>
> 

Thanks,

  Paul

> --
> Anthony PERARD