Re: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
672cebc qapi/machine.json: Add RX cpu.
5470489 BootLinuxConsoleTest: Test the RX-Virt machine
7c0507a Add rx-softmmu
2f5604b hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
35359c6 hw/rx: Honor -accel qtest
4e38d1e hw/rx: RX Target hardware definition
5eed65b hw/char: RX62N serial communication interface (SCI)
70855a7 hw/timer: RX62N internal timer modules
9fdcd72 hw/intc: RX62N interrupt controller (ICUa)
2e4ae69 target/rx: Dump bytes for each insn during disassembly
25ff366 target/rx: Collect all bytes during disassembly
8ec9dc5 target/rx: Emit all disassembly in one prt()
be71e73 target/rx: Use prt_ldmi for XCHG_mr disassembly
aa2175d target/rx: Replace operand with prt_ldmi in disassembler
48ed0fb target/rx: Disassemble rx_index_addr into a string
d4bbb21 target/rx: RX disassembler
cc17d1a target/rx: CPU definition
27b404b target/rx: TCG helper
4d35681 target/rx: TCG translation
6c2f3d2 hw/registerfields.h: Add 8bit and 16bit register macros
bd8a862 qemu/bitops.h: Add extract8 and extract16
2ab4d1d MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 2ab4d1de3b6b (MAINTAINERS: Add RX)
2/22 Checking commit bd8a8623b650 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 6c2f3d225fa5 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 4d356815dd13 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 27b404b9078d (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit cc17d1accf57 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit d4bbb21de8d1 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 48ed0fb6bc35 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit aa2175df5901 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit be71e734f793 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit 8ec9dc58c13f (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit 25ff366929de (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit 2e4ae6986d66 (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 9fdcd721382e (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 70855a767490 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 5eed65b22dee (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 4e38d1ec8a27 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 35359c66753f (hw/rx: Honor -accel qtest)
19/22 Checking commit 2f5604b4ac6c (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit 7c0507a16ffd (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 59 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 5470489924c3 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 672cebcb0d1f (qapi/machine.json: Add RX cpu.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden