[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_help
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_helper with callback |
Date: |
Wed, 11 Sep 2019 09:20:15 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/11/19 9:07 AM, Philippe Mathieu-Daudé wrote:
>> {
>> return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
>> - full_le_lduw_mmu);
>> + full_le_lduw_mmu, direct_lduw_le);
>
> Why not cast lduw_be_p? (except for direct_ldub).
>
> return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
> full_le_lduw_mmu, (DirectLoadHelper)lduw_be_p);
>
> Useful to set breakpoint while debugging?
Because the types in the function signature are different,
and such a cast will cause misbehavior.
r~
- [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation, Richard Henderson, 2019/09/10
- [Qemu-devel] [PATCH 3/3] cputlb: Introduce TLB_BSWAP, Richard Henderson, 2019/09/10
- Re: [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation, no-reply, 2019/09/10
- Re: [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation, no-reply, 2019/09/11
- Re: [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation, no-reply, 2019/09/11