Re: [Qemu-devel] [PATCH V2 2/2] block/nfs: add support for nfs_umount

[Max Reitz]

On 10.09.19 17:41, Peter Lieven wrote:
> libnfs recently added support for unmounting. Add support
> in Qemu too.
> 
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block/nfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/block/nfs.c b/block/nfs.c
> index 2c98508275..f39acfdb28 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -398,6 +398,9 @@ static void nfs_client_close(NFSClient *client)
>              nfs_close(client->context, client->fh);
>              client->fh = NULL;
>          }
> +#ifdef LIBNFS_FEATURE_UMOUNT
> +        nfs_umount(client->context);
> +#endif
>          nfs_destroy_context(client->context);
>          client->context = NULL;
>      }

I don’t understand what unmounting means in this context.  Is it just
generic clean-up for NFSv3 (it appears that it’s a no-op for NFSv4)?
Why isn’t that done by nfs_destroy_context()?

Max

signature.asc
Description: OpenPGP digital signature