Re: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc 
improvements
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
a1653d5 qapi: Tweak code to match docs/devel/qapi-code-gen.txt
099aa0e docs/devel/qapi-code-gen: Improve QAPI schema language doc
831ceca docs/devel/qapi-code-gen: Rewrite introduction to schema
b2d2173 docs/devel/qapi-code-gen: Rewrite compatibility considerations
e3fee5f docs/devel/qapi-code-gen: Reorder sections for readability
5a3026a qapi: Adjust frontend errors to say enum value, not member
da3e5ce qapi: Permit omitting all flat union branches
29a78dc qapi: Permit alternates with just one branch
1690f90 qapi: Permit 'boxed' with empty type
4db101b qapi: Drop support for escape sequences other than \\
226a021 qapi: Restrict strings to printable ASCII
b7bf351 tests/qapi-schema: Demonstrate bad reporting of funny characters
e4bbc54 docs/devel/qapi-code-gen: Minor specification fixes
afba881 qapi: Drop support for boxed alternate arguments
1988fff qapi: Drop check_type()'s redundant parameter @allow_optional
2f4a210 scripts/git.orderfile: Match QAPI schema more precisely

=== OUTPUT BEGIN ===
1/16 Checking commit 2f4a2105c5e3 (scripts/git.orderfile: Match QAPI schema 
more precisely)
2/16 Checking commit 1988fff693a1 (qapi: Drop check_type()'s redundant 
parameter @allow_optional)
3/16 Checking commit afba881b77d4 (qapi: Drop support for boxed alternate 
arguments)
4/16 Checking commit e4bbc5479810 (docs/devel/qapi-code-gen: Minor 
specification fixes)
5/16 Checking commit b7bf3512c9eb (tests/qapi-schema: Demonstrate bad reporting 
of funny characters)
6/16 Checking commit 226a021e435b (qapi: Restrict strings to printable ASCII)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#115: FILE: tests/qapi-schema/string-code-point-127.json:2:
+{ 'command': '⌦' }
               ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#141: FILE: tests/qapi-schema/string-code-point-31.json:2:
+{ 'command': '␟' }
               ^

total: 2 errors, 1 warnings, 67 lines checked

Patch 6/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/16 Checking commit 4db101b60dce (qapi: Drop support for escape sequences 
other than \\)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/16 Checking commit 1690f908e9c9 (qapi: Permit 'boxed' with empty type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#129: 
deleted file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit 29a78dc3574f (qapi: Permit alternates with just one branch)
10/16 Checking commit da3e5ce8445d (qapi: Permit omitting all flat union 
branches)
11/16 Checking commit 5a3026a89b6c (qapi: Adjust frontend errors to say enum 
value, not member)
12/16 Checking commit e3fee5f2aebc (docs/devel/qapi-code-gen: Reorder sections 
for readability)
13/16 Checking commit b2d2173f6812 (docs/devel/qapi-code-gen: Rewrite 
compatibility considerations)
14/16 Checking commit 831cecae22b1 (docs/devel/qapi-code-gen: Rewrite 
introduction to schema)
15/16 Checking commit 099aa0e26496 (docs/devel/qapi-code-gen: Improve QAPI 
schema language doc)
16/16 Checking commit a1653d5a7388 (qapi: Tweak code to match 
docs/devel/qapi-code-gen.txt)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden