[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/16] qapi: Drop check_type()'s redundant pa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional |
Date: |
Tue, 10 Sep 2019 08:45:40 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/10/19 1:37 AM, Markus Armbruster wrote:
> check_type() uses @allow_optional only when @value is a dictionary and
> @allow_dict is True. All callers that pass allow_dict=True also pass
> allow_optional=True.
>
> Therefore, @allow_optional is always True when check_type() uses it.
> Drop the redundant parameter.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi/common.py | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional, Markus Armbruster, 2019/09/10
- Re: [Qemu-devel] [PATCH v2 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional,
Eric Blake <=
- [Qemu-devel] [PATCH v2 03/16] qapi: Drop support for boxed alternate arguments, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 01/16] scripts/git.orderfile: Match QAPI schema more precisely, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 04/16] docs/devel/qapi-code-gen: Minor specification fixes, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 11/16] qapi: Adjust frontend errors to say enum value, not member, Markus Armbruster, 2019/09/10