Re: [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf()

[Stefano Garzarella]

On Tue, Sep 10, 2019 at 10:54:25AM +0100, Peter Maydell wrote:
> On Tue, 10 Sep 2019 at 10:50, Alex Bennée <address@hidden> wrote:
> > Seem sensible enough (although gah, I hate these glue bits). Would the
> > large amount of goto fail logic be something that could be cleaned up
> > with the automatic cleanup functions we recently mentioned in
> > CODING_STYLE.rst?
> 
> Probably not, because one bit of cleanup we *should* be doing
> in the fail-exit codepaths but currently don't is to delete
> any rom blobs we created for earlier segments in the ELF file
> before we gave up, so we need to have an error-exit path anyway...

Mmm right, I should add a new API (e.g. rom_remove()) to do this better
cleanup.

> 
> thanks
> -- PMM
>