[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in i
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr |
|
Date: |
Tue, 10 Sep 2019 11:37:12 +0200 |
|
User-agent: |
NeoMutt/20180716 |
On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> In "if (saddr->keep_alive) {" we may already be on error path, with
> invalid sock < 0. Fix it by returning error earlier.
>
> Reported-by: Coverity (CID 1405300)
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> util/qemu-sockets.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella <address@hidden>