[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environm
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables |
|
Date: |
Fri, 6 Sep 2019 22:56:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 06/09/2019 à 18:57, Max Filippov a écrit :
> QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to
> do it again in main.
>
> Signed-off-by: Max Filippov <address@hidden>
> ---
> linux-user/main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index c9d97d2b1fc6..22ae2b3e65d1 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp)
>
> thread_cpu = cpu;
>
> - if (getenv("QEMU_STRACE")) {
> - do_strace = 1;
> - }
> -
> - if (seed_optarg == NULL) {
> - seed_optarg = getenv("QEMU_RAND_SEED");
> - }
> {
> Error *err = NULL;
> if (seed_optarg != NULL) {
>
Reviewed-by: Laurent Vivier <address@hidden>