[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI sup
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI support |
|
Date: |
Fri, 6 Sep 2019 19:01:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 06/09/2019 à 18:55, Max Filippov a écrit :
> On Fri, Sep 6, 2019 at 2:33 AM Laurent Vivier <address@hidden> wrote:
>> Le 26/08/2019 à 21:58, Max Filippov a écrit :
>>> +#if defined(TARGET_XTENSA)
>>> + if (getenv("QEMU_XTENSA_ABI_CALL0")) {
>>> + xtensa_set_abi_call0();
>>> + }
>>
>> Not needed, this is done by parse_args() that checks
>> getenv(arginfo->env) and calls arginfo->handle_opt()
>> (handle_arg_abi_call0()).
>
> Thank you, I'll fix that. I got confused by the similar handling of
> QEMU_STRACE, I'll post a cleanup that removes that as well.
Good point.
It seems getenv("QEMU_STRACE") and getenv("QEMU_RAND_SEED") could be
removed.
Thanks,
Laurent