[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery |
Date: |
Fri, 06 Sep 2019 15:35:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> We've got max-postcopy-bandwidth parameter but it's not applied
> correctly after a postcopy recovery so the recovered migration stream
> will still eat the whole net bandwidth. Fix that up.
>
> Reported-by: Xiaohui Li <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> migration/migration.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Juan Quintela <address@hidden>
> diff --git a/migration/migration.c b/migration/migration.c
> index 8b9f2fe30a..b307813aa3 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3327,7 +3327,8 @@ void migrate_fd_connect(MigrationState *s, Error
> *error_in)
>
> if (resume) {
> /* This is a resumed migration */
> - rate_limit = INT64_MAX;
> + rate_limit = s->parameters.max_postcopy_bandwidth /
> + XFER_LIMIT_RATIO;
> } else {
> /* This is a fresh new migration */
> rate_limit = s->parameters.max_bandwidth / XFER_LIMIT_RATIO;
I was confused thinking that the two assignations were the same O:-)