Re: [Qemu-devel] [PATCH v1 02/42] configure: clean-up container cross compile detect

[David Hildenbrand]

On 05.09.19 20:35, Alex Bennée wrote:
> 
> David Hildenbrand <address@hidden> writes:
> 
>> On 04.09.19 22:29, Alex Bennée wrote:
>>> The introduction of podman support inadvertently broke configure's
>>> detect of the container support as the configure probe didn't specify
>>> an engine type. To fix this in docker.py:
>>>
>>>   - only (re)set USE_ENGINE if --engine is specified
>>>   - enhance the output so docker is no longer just yes
>>>
>>> In the configure script we can at least start cleaning up the
>>> detecting and naming of variables. To avoid too much churn the
>>> conversion of the various make DOCKER_foo variables has been left for
>>> future clean-ups.
>>
>> This is not only a "clean-up" but an actual fix :) (maybe add a Fixes:
>> tag).
> 
> Done... do I get a Tested-by: ?

Most certainly, you saved me quite some time today:

Tested-by: David Hildenbrand <address@hidden>

Thanks!

-- 

Thanks,

David / dhildenb