[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qt
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code |
Date: |
Wed, 4 Sep 2019 19:52:23 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Sep 04, 2019 at 03:00:44PM +0200, Thomas Huth wrote:
> Library functions should not rely on functions that require global_qtest
> (since they might get used in tests that deal with multiple states).
> Commit 1999a70a05ad603d ("Make generic virtio code independent from
> global_qtest") already tried to clean the libqos virtio code, but I
> missed to replace the clock_step() function. Thus change it now to
> qtest_clock_step() instead.
> The logic of the qvirtio_wait_config_isr() function is now pushed
> to the virtio-mmio.c and virtio-pci.c files instead, since we can
> get the QTestState here easily.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> tests/libqos/virtio-mmio.c | 14 +++++++++++++-
> tests/libqos/virtio-pci.c | 14 +++++++++++++-
> tests/libqos/virtio.c | 20 ++++++--------------
> tests/libqos/virtio.h | 6 +++---
> tests/virtio-blk-test.c | 3 ++-
> 5 files changed, 37 insertions(+), 20 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 0/6] Make the core libqtest library independe from global_qtest, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 1/6] tests/migration: Do not use functions anymore that rely on global_qtest, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 4/6] tests: Remove unnecessary global_qtest references, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 6/6] tests/libqtest: Use libqtest-single.h in tests that require global_qtest, Thomas Huth, 2019/09/04
- [Qemu-devel] [PATCH v2 5/6] tests/libqtest: Move global_test wrapper function into a separate header, Thomas Huth, 2019/09/04