Re: [Qemu-devel] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync()

[Eric Blake]

On 8/20/19 5:48 AM, Juan Quintela wrote:
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  blockdev-nbd.c            | 2 +-
>  chardev/char-socket.c     | 2 +-
>  include/io/net-listener.h | 2 ++
>  io/net-listener.c         | 3 ++-
>  migration/socket.c        | 2 +-
>  qemu-nbd.c                | 2 +-
>  ui/vnc.c                  | 4 ++--
>  7 files changed, 10 insertions(+), 7 deletions(-)

Just now noticing this one, even though the pull request is already sent...

> 
> diff --git a/blockdev-nbd.c b/blockdev-nbd.c
> index 7a71da447f..c621686131 100644
> --- a/blockdev-nbd.c
> +++ b/blockdev-nbd.c
> @@ -101,7 +101,7 @@ void nbd_server_start(SocketAddress *addr, const char 
> *tls_creds,
>      qio_net_listener_set_name(nbd_server->listener,
>                                "nbd-listener");
>  
> -    if (qio_net_listener_open_sync(nbd_server->listener, addr, errp) < 0) {
> +    if (qio_net_listener_open_sync(nbd_server->listener, addr, 1, errp) < 0) 
> {
>          goto error;
>      }

Does this interfere with the ability to have more than one client
connect to an NBD server during pull-mode incremental backup?  Or can
you still have multiple simultaneous clients, provided that the server
has finished accepting the connection from the first before the second
one starts?

> +++ b/qemu-nbd.c
> @@ -1054,7 +1054,7 @@ int main(int argc, char **argv)
>      server = qio_net_listener_new();
>      if (socket_activation == 0) {
>          saddr = nbd_build_socket_address(sockpath, bindto, port);
> -        if (qio_net_listener_open_sync(server, saddr, &local_err) < 0) {
> +        if (qio_net_listener_open_sync(server, saddr, 1, &local_err) < 0) {

Here, 'qemu-nbd -e $n' allows up to $n simultaneous clients.  Should we
be feeding in that number, instead of a hard-coded 1, to make it easier
for those clients to connect simultaneously?

We can make such changes as a followup patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature