[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos fun
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest |
Date: |
Tue, 3 Sep 2019 10:34:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 03/09/2019 08:18, Thomas Huth wrote:
> libqos library functions should never depend on functions (like memread(),
> memwrite() or clock_step()) that require global_qtest to be set, since
> library functions might get used in qtests that track multiple states, too.
> Thus let's replace the global_qtest-related functions with their independent
> counterparts.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> tests/libqos/e1000e.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH 0/6] Make the core libqtest library independe from global_qtest, Thomas Huth, 2019/09/03
- [Qemu-devel] [PATCH 1/6] tests/migration: Do not use functions anymore that rely on global_qtest, Thomas Huth, 2019/09/03
- [Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest, Thomas Huth, 2019/09/03
- Re: [Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest,
Laurent Vivier <=
- [Qemu-devel] [PATCH 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code, Thomas Huth, 2019/09/03
- [Qemu-devel] [PATCH 4/6] tests: Remove unnecessary global_qtest references, Thomas Huth, 2019/09/03
- [Qemu-devel] [PATCH 5/6] tests/libqtest: Move global_test wrapper function into a separate header, Thomas Huth, 2019/09/03
- [Qemu-devel] [PATCH 6/6] tests/libqtest: Use libqtest-single.h in tests that require global_qtest, Thomas Huth, 2019/09/03