Re: [Qemu-devel] [PATCH] tests/acceptance: Do not install paramiko module by default

[Eduardo Habkost]

On Fri, Aug 30, 2019 at 08:40:33PM +0200, Philippe Mathieu-Daudé wrote:
> The paramiko Python module has many dependencies. Some of them
> are not pure Python, such cryptography module which requires to
> be built and linked with OpenSSL.
> 
> When native libraries and header are missing on the host, the
> error reported is not very helpful:
> 
>   $ make check-venv
>   VENV    tests/venv
>   PIP     tests/requirements.txt
>   Command "tests/venv/bin/python -u -c "import setuptools, 
> tokenize;__file__='/tmp/pip-build-la4el5r5/cryptography/setup.py';f=getattr(tokenize,
>  'open', open)(__file__);code=f.read().replace('\r\n', 
> '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record 
> /tmp/pip-1efs22iz-record/install-record.txt 
> --single-version-externally-managed --compile --install-headers 
> tests/venv/include/site/python3.6/cryptography" failed with error code 1 in 
> /tmp/pip-build-la4el5r5/cryptography/
> 
> Since currently the tests depending on paramiko are targetting
> very specific uses, we can avoid the strong dependency on the
> paramiko module, to let systems where it does not build properly
> work the rest of the tests.
> If paramiko is manually installed, the tests using it will be
> automatically run.
> 
> Fixes: c47c336e870
> Reported-by: David Gibson <address@hidden>
> Suggested-by: Cleber Rosa <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Thanks!  Queued on python-next.

-- 
Eduardo