Re: [Qemu-devel] [EXTERNAL][PATCH v2 00/30] Clean up handling of configuration register CP0

[Aleksandar Rikalo]

> From: Aleksandar Markovic <address@hidden>
> Sent: Wednesday, August 28, 2019 6:26 PM
> To: address@hidden <address@hidden>
> Cc: Aleksandar Markovic <address@hidden>; Aleksandar Rikalo <address@hidden>
> Subject: [EXTERNAL][PATCH v2 00/30] Clean up handling of configuration 
> register CP0
>
> From: Aleksandar Markovic <address@hidden>
>
> v1->v2:
>
>   - added cleanup of handling six more registers
>   - misc improvements
>
> This series is a spin-off of a former "Misc MIPS fixes for 4.2" series.
>
> The goal of the series is to clean up CP0-related code, and prepare
> it for (near) future extensions and amendments.
>
> The series is mostly of refactoring nature, however it may contain
> simple fixes (for example, fixes for obvious bugs, or additions of
> simple subregister handling). The more complex fixes and improvements
> (for example, additions of VPE-related functionalities) are, for now,
> outside the scope of this series.
>
> Aleksandar Markovic (30):
>   target/mips: Clean up handling of CP0 register 0
>   target/mips: Clean up handling of CP0 register 1
>   target/mips: Clean up handling of CP0 register 2
>   target/mips: Clean up handling of CP0 register 3
>   target/mips: Clean up handling of CP0 register 4
>   target/mips: Clean up handling of CP0 register 5
>   target/mips: Clean up handling of CP0 register 6
>   target/mips: Clean up handling of CP0 register 7
>   target/mips: Clean up handling of CP0 register 8
>   target/mips: Clean up handling of CP0 register 9
>   target/mips: Clean up handling of CP0 register 10
>   target/mips: Clean up handling of CP0 register 11
>   target/mips: Clean up handling of CP0 register 12
>   target/mips: Clean up handling of CP0 register 13
>   target/mips: Clean up handling of CP0 register 14
>   target/mips: Clean up handling of CP0 register 15
>   target/mips: Clean up handling of CP0 register 16
>   target/mips: Clean up handling of CP0 register 17
>   target/mips: Clean up handling of CP0 register 18
>   target/mips: Clean up handling of CP0 register 19
>   target/mips: Clean up handling of CP0 register 20
>   target/mips: Clean up handling of CP0 register 23
>   target/mips: Clean up handling of CP0 register 24
>   target/mips: Clean up handling of CP0 register 25
>   target/mips: Clean up handling of CP0 register 26
>   target/mips: Clean up handling of CP0 register 27
>   target/mips: Clean up handling of CP0 register 28
>   target/mips: Clean up handling of CP0 register 29
>   target/mips: Clean up handling of CP0 register 30
>   target/mips: Clean up handling of CP0 register 31
>
>  target/mips/cpu.h       |  113 ++++-
>  target/mips/translate.c | 1150 
> ++++++++++++++++++++++++-----------------------
>  2 files changed, 681 insertions(+), 582 deletions(-)
>
> --
> 2.7.4

The series looks good to me. It would be nice to include MTTP and MFTR handling 
in future cleanups.

Reviewed-by: Aleksandar Rikalo <address@hidden>