[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initi
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array |
|
Date: |
Wed, 28 Aug 2019 15:48:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 28.08.19 15:47, Cornelia Huck wrote:
> On Wed, 28 Aug 2019 15:42:37 +0200
> Thomas Huth <address@hidden> wrote:
>
>> On 28/08/2019 15.27, Christian Borntraeger wrote:
>>> On 28.08.19 14:33, Thomas Huth wrote:
>>>> We're clearing the BSS in start.S now, so there is no need to
>>>> pre-initialize the loadparm_str array with zeroes anymore.
>>>
>>> Can you add a link to the commit that does the bss clearing?
>>
>> Sure, I'll change the description to:
>>
>> "
>> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
>> zero out bss section"), we are clearing now the BSS in start.S, so there
>> is no need to pre-initialize the loadparm_str array with zeroes anymore.
>> "
>>
>> Thomas
>
> With that:
>
> Reviewed-by: Cornelia Huck <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Thomas are you going to pick this up or shall I do it?