Re: [Qemu-devel] [PATCH v4] riscv: hmp: Add a command to show virtual memory mappings

[Bin Meng]

Hi Palmer,

On Wed, Aug 28, 2019 at 7:18 AM Palmer Dabbelt <address@hidden> wrote:
>
> On Sun, 18 Aug 2019 22:59:54 PDT (-0700), address@hidden wrote:
> > On Wed, Aug 14, 2019 at 11:33 PM Bin Meng <address@hidden> wrote:
> >>
> >> This adds 'info mem' command for RISC-V, to show virtual memory
> >> mappings that aids debugging.
> >>
> >> Rather than showing every valid PTE, the command compacts the
> >> output by merging all contiguous physical address mappings into
> >> one block and only shows the merged block mapping details.
> >>
> >> Signed-off-by: Bin Meng <address@hidden>
> >> Acked-by: Dr. David Alan Gilbert <address@hidden>
> >> Reviewed-by: Palmer Dabbelt <address@hidden>
> >>
> >> ---
> >>
> >> Changes in v4:
> >> - restore to v2, that does not print all harts's PTE, since we
> >>   should switch to a cpu context via the 'cpu' command
> >>
> >> Changes in v3:
> >> - print PTEs for all harts instead of just current hart
> >>
> >> Changes in v2:
> >> - promote ppn to hwaddr when doing page table address calculation
> >>
> >>  hmp-commands-info.hx       |   2 +-
> >>  target/riscv/Makefile.objs |   4 +
> >>  target/riscv/monitor.c     | 229 
> >> +++++++++++++++++++++++++++++++++++++++++++++
> >>  3 files changed, 234 insertions(+), 1 deletion(-)
> >>  create mode 100644 target/riscv/monitor.c
> >>
> >
> > Ping?
> >
> > What's the status of this patch?
>
> This is in my patch queue (for-master on github).  I'm still a bit backed up 
> on
> email, but when I get caught back up I'll send a PR.

I double checked your git repo, and found you applied an older version
of this patch.

Please drop that, and apply this v4 one.
http://patchwork.ozlabs.org/patch/1147104/

Regards,
Bin