[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/7] tcg: probe_write() refactor
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/7] tcg: probe_write() refactorings |
Date: |
Tue, 27 Aug 2019 18:09:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 26.08.19 09:51, David Hildenbrand wrote:
> Based on tcg-next. The last two patches from v1 are now part of
> "[PATCH 0/6] exec: Cleanup watchpoints" from richard.
>
> Fix and refactore some things around probe_write() in s390x code. Introduce
> probe_write() for CONFIG_USER_ONLY.
>
> This is the first step of some changes necessary to handle fault-safe
> access accross multiple pages on s390x. The next step is making
> probe_write() return an address, similar to tlb_vaddr_to_host(), and
> introduing probe_read().
>
> v1 -> v2:
> - "tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code"
> -- Perform only a single !guest_addr_valid(addr) check.
> - "tcg: Enforce single page access in probe_write()"
> -- Also add the check for CONFIG_USER_ONLY
>
> Cc: Richard Henderson <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Riku Voipio <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Aleksandar Markovic <address@hidden>
> Cc: Aleksandar Rikalo <address@hidden>
> Cc: Cornelia Huck <address@hidden>
>
> David Hildenbrand (7):
> s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in
> probe_write_access()
> s390x/tcg: Fix length calculation in probe_write_access()
> tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code
> tcg: Enforce single page access in probe_write()
> mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well
> hppa/tcg: Call probe_write() also for CONFIG_USER_ONLY
> s390x/tcg: Pass a size to probe_write() in do_csst()
>
> accel/tcg/cputlb.c | 2 ++
> accel/tcg/user-exec.c | 17 +++++++++++++++++
> include/exec/exec-all.h | 4 ++--
> target/hppa/op_helper.c | 2 --
> target/mips/op_helper.c | 8 +++-----
> target/s390x/mem_helper.c | 13 ++-----------
> 6 files changed, 26 insertions(+), 20 deletions(-)
>
Richard, in case there is no more feedback, will you take these patches
via your tree?
--
Thanks,
David / dhildenb
- Re: [Qemu-devel] [PATCH v2 2/7] s390x/tcg: Fix length calculation in probe_write_access(), (continued)
- [Qemu-devel] [PATCH v2 3/7] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code, David Hildenbrand, 2019/08/26
- [Qemu-devel] [PATCH v2 4/7] tcg: Enforce single page access in probe_write(), David Hildenbrand, 2019/08/26
- [Qemu-devel] [PATCH v2 5/7] mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well, David Hildenbrand, 2019/08/26
- [Qemu-devel] [PATCH v2 6/7] hppa/tcg: Call probe_write() also for CONFIG_USER_ONLY, David Hildenbrand, 2019/08/26
- [Qemu-devel] [PATCH v2 7/7] s390x/tcg: Pass a size to probe_write() in do_csst(), David Hildenbrand, 2019/08/26
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/7] tcg: probe_write() refactorings,
David Hildenbrand <=