[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vq
|
From: |
Raphael Norwitz |
|
Subject: |
Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs |
|
Date: |
Thu, 22 Aug 2019 10:30:13 -0700 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Thu, Aug 22, 2019 at 10:58:02AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Raphael, Stefan,
>
> On 6/14/19 11:18 AM, Stefan Hajnoczi wrote:
> > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote:
> >> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl
> >> and event without a physical address. This can cause
> >> vhost_verify_ring_part_mapping to return ENOMEM, causing
> >> the following logs:
> >>
> >> qemu-system-x86_64: Unable to map available ring for ring 0
> >> qemu-system-x86_64: Verify ring failure on region 0
> >>
> >> The qemu commit e6cc11d64fc998c11a4dfcde8fda3fc33a74d844
> >> has already resolved the issue for vhost scsi devices but
> >> the fix was never applied to vhost-user scsi devices.
> >>
> >> Signed-off-by: Raphael Norwitz <address@hidden>
> >> ---
> >> hw/scsi/vhost-user-scsi.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> >
>
> What about backends/vhost-user.c and hw/block/vhost-user-blk.c?
>
It is clearly an issue for hw/block/vhost-user-blk.c The code is very
similar.
backends/vhost-user.c also fails to zero out the vqs.
I will send the patches.