[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug |
|
Date: |
Thu, 22 Aug 2019 16:54:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/22/19 3:38 PM, Markus Armbruster wrote:
> pr_manager_worker() passes its @opaque argument to g_free(). Wrong;
> it points to pr_manager_worker()'s automatic @data. Broken when
> commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix
> by deleting the g_free().
>
> Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scsi/pr-manager.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c
> index ee43663576..0c866e8698 100644
> --- a/scsi/pr-manager.c
> +++ b/scsi/pr-manager.c
> @@ -39,7 +39,6 @@ static int pr_manager_worker(void *opaque)
> int fd = data->fd;
> int r;
>
> - g_free(data);
> trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]);
>
> /* The reference was taken in pr_manager_execute. */
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>