[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen |
Date: |
Thu, 22 Aug 2019 15:19:20 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Tue, Aug 20, 2019 at 01:17:59PM +0200, Juan Quintela wrote:
> Daniel P. Berrangé <address@hidden> wrote:
> > On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote:
> >> Current parameter was always one. We continue with that value for now
> >> in all callers.
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
> >>
> >> ---
> >> Moved trace to socket_listen
> >> ---
> >> include/qemu/sockets.h | 2 +-
> >> io/channel-socket.c | 2 +-
> >> qga/channel-posix.c | 2 +-
> >> tests/test-util-sockets.c | 12 ++++++------
> >> util/qemu-sockets.c | 33 ++++++++++++++++++++++-----------
> >> util/trace-events | 3 +++
> >> 6 files changed, 34 insertions(+), 20 deletions(-)
> >
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
>
> Hi
>
> Everything is reviewed by you, and it is mostly socket code. Should I
> do the pull request, or are you doing it?
I'm fine if you want to send a PR, since this is ultimately about
fixing migration problems.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v3 0/5] Fix multifd with big number of channels, Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v3 2/5] socket: Add num connections to qio_channel_socket_sync(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v3 3/5] socket: Add num connections to qio_channel_socket_async(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v3 5/5] multifd: Use number of channels as listen backlog, Juan Quintela, 2019/08/20