[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] xhci: Add No Op Command
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/5] xhci: Add No Op Command |
Date: |
Thu, 22 Aug 2019 08:52:40 +0200 |
From: Hikaru Nishida <address@hidden>
This commit adds No Op Command (23) to xHC for verifying the operation
of the Command Ring mechanisms.
No Op Command is defined in XHCI spec (4.6.2) and just reports Command
Completion Event with Completion Code == Success.
Before this commit, No Op Command is not implemented so xHC reports
Command Completion Event with Completion Code == TRB Error. This commit
fixes this behaviour to report Completion Code correctly.
Signed-off-by: Hikaru Nishida <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-xhci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index f698224c8a06..f5782649482b 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2543,6 +2543,9 @@ static void xhci_process_commands(XHCIState *xhci)
case CR_GET_PORT_BANDWIDTH:
event.ccode = xhci_get_port_bandwidth(xhci, trb.parameter);
break;
+ case CR_NOOP:
+ event.ccode = CC_SUCCESS;
+ break;
case CR_VENDOR_NEC_FIRMWARE_REVISION:
if (xhci->nec_quirks) {
event.type = 48; /* NEC reply */
--
2.18.1
- [Qemu-devel] [PULL 0/5] Usb 20190822 patches, Gerd Hoffmann, 2019/08/22
- [Qemu-devel] [PULL 3/5] xhci: Add No Op Command,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/5] ehci: fix queue->dev null ptr dereference, Gerd Hoffmann, 2019/08/22
- [Qemu-devel] [PULL 2/5] usb-redir: merge interrupt packets, Gerd Hoffmann, 2019/08/22
- [Qemu-devel] [PULL 1/5] usbredir: fix buffer-overflow on vmload, Gerd Hoffmann, 2019/08/22
- [Qemu-devel] [PULL 4/5] usb: reword -usb command-line option and mention xHCI, Gerd Hoffmann, 2019/08/22
- Re: [Qemu-devel] [PULL 0/5] Usb 20190822 patches, Peter Maydell, 2019/08/22